Multiple Backup Delete

[BobParticipant]

I just updated to 2.11.12.20. Attempted to follow the instructions for multiple backup delete at https://updraftplus.com/faqs/how-can-i-delete-multiple-backup-sets-at-once/. I’m not able to select backup sets as described. All control-click does is to bring up the context menu. Tried various other key combinations and clicking in different places–nothing results in selecting a backup set as is shown in the instructions.

[udadminKeymaster]

Hi Bob,

Probably something else on the computer or browser or website site is intercepting the pressing of Control… you’d need to go through a process of elimination to work out which.

David

[BobParticipant]

I’ve just tried it on multiple sites/machines/browsers. And I think here’s where the problem lies: It always works if I’m using a PC, always fails if I’m using a Mac. On a Mac, the control-click combination has a special meaning: bring up the context menu. It accomplishes the same thing as a right click on a mouse, but is intended for MacBooks with their trackpads and Apple one-button mice. It’s one of the most fundamental keyboard/mouse combinations on a Mac, and I suspect the O/S intercepts it at a low level.

[udadminKeymaster]

Hi Bob,

If you edit wp-content/plugins/updraftplus/includes/updraft-admin-ui.js in a text editor and find the line…

if (! e.ctrlKey) return;

… and replace it with :

if (! e.ctrlKey && ! e.cmdKey) return;

… then use the command key: does that work? (Make sure you reload the page first; you may also need to flush your browser cache, and/or try a different browser, otherwise the changed JavaScript may not actually load).

David

[BobParticipant]

That doesn’t work. And I can follow it in the debugger and see it fails the test.

But if I change it to:

if (! e.ctrlKey && ! e.metaKey) return;

that DOES work.

Some quick Googling led me to a few Stack Overflow discussions about the meaning of metaKey on different keyboards, so while it does work on the Macs I tried, I’m not sure it’s the end of the story. I did try a bunch of other modifier keys (on Mac, not PC), and only the command key resulted in the backup row selection.

Thanks.

Bob

[udadminKeymaster]

Hi Bob,

OK – we’ll add that to the next release.

David

[BobParticipant]

Great. But just to confirm, I’m not sure that simply adding metaKey might not have some unwanted side-effects–perhaps on a PC or Linux client. That’s something you’re going to research if necessary, correct?

Thanks.

[udadminKeymaster]

Hi Bob,

On a Windows keyboard (which is also what Linux users generally have), it’s the Windows key. So, it’d open the Windows menu if they press it. But they should press the Control key instead.

David

[BobParticipant]

Ah, OK.

Thanks again.

Bob

[Author]

Posts