validation and sanitization of “Backup directory” setting

By mistyping I have been able to input
“..\updraft-backups” instead of my usual “../updraft-backups”
into the advanced setting “Backup directory”.

I know this is a perfectly valid unix file/folder name, but it actually got written on the file system and throw off-balance my windows-based ftp client (WebDrive).

No big deal, I was able to fix this easyly, but I would suggest the team to substitute the back slashes with forward slashes (at client side) just to help the user in the most common case.
(if one really wants to input a backslash I suppose he can fiddle with the option on the db or bypass the validator on the client side).

What do you think?

twitterlinkedinFacebook

2 Comments

  1. udadmin

    Hi Vittorio,

    I don’t think there’s much likelihood we’d implement this. It is marked as an “Expert” setting, and if what is entered is valid, then second-guessing the user to change it to something else isn’t something we’d want to do. I’d expect that normally if the user changes that setting, he’d then run a backup and make sure it’s using the directory he expects, upon which any error will then become apparent.

    David

  2. Vittorio

    Hmm. Expert doesn’t mean “without parachute” :)
    >>second-guessing the user to change it to something else isn’t something we’d want to do
    I totally agree, but you have to admit that “my\foldername” in unix has no other meanining than “my/foldername”.
    Btw afaik is a bad habit having backslashes in names in unix.

    I don’t know: as a programmer every fiber of me tells me that you are absolutely right; even if you want to sanitize that input that wouldn’t be the level to do it.
    But as a user I find it inconceivably abstract the chance that someone would actually use backslashes in a filename; and on the other hand removing that rogue folder is beiing really hard for me without console access.

    One last suggestion and then I quit: why not just an inline red warning “are you sure about the back slashes?”
    Goodbye, thank you!

Submit a Comment